[riot-commits] [RIOT-OS/RIOT] 210a20: core: msg: don't wake up sender after receive if i...

Christian Mehlis mehlis at inf.fu-berlin.de
Sun Feb 16 11:02:12 CET 2014


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 210a20b807a8a0b816015c350ca60224bc6199d7
      https://github.com/RIOT-OS/RIOT/commit/210a20b807a8a0b816015c350ca60224bc6199d7
  Author: Kaspar Schleiser <kaspar at schleiser.de>
  Date:   2014-02-12 (Wed, 12 Feb 2014)

  Changed paths:
    M core/msg.c

  Log Message:
  -----------
  core: msg: don't wake up sender after receive if it's REPLY_BLOCKED

solves issue #100

If the sender is reply-blocked, waking it up after its message has been
delivered is wrong. It needs to stay reply-blocked until the reply has
been delivered.


  Commit: 8d07b131db2d84a6c426b98258f68aa57236c38b
      https://github.com/RIOT-OS/RIOT/commit/8d07b131db2d84a6c426b98258f68aa57236c38b
  Author: Kaspar Schleiser <kaspar at schleiser.de>
  Date:   2014-02-12 (Wed, 12 Feb 2014)

  Changed paths:
    M core/msg.c

  Log Message:
  -----------
  core: msg: add some debug statements


  Commit: 622d473eb31e4ab5486e2eee1d2e2f6f0f7b4f14
      https://github.com/RIOT-OS/RIOT/commit/622d473eb31e4ab5486e2eee1d2e2f6f0f7b4f14
  Author: Kaspar Schleiser <kaspar at schleiser.de>
  Date:   2014-02-13 (Thu, 13 Feb 2014)

  Changed paths:
    M core/msg.c

  Log Message:
  -----------
  core: msg: yield after queueing of a message if REPLY_BLOCKED

When setting the running task reply_blocked, it is implicitly removed
from the runqueue. But if queueing of a msg is actually successful, the
thread exits msg_send without yielding, continuing to run even if it's
not supposed to.

Nice example of why multiple function exit points lead to weird
errors...


  Commit: 7092ac629c40e6f3ffdc752a4d6074b5536afa43
      https://github.com/RIOT-OS/RIOT/commit/7092ac629c40e6f3ffdc752a4d6074b5536afa43
  Author: Christian Mehlis <mehlis at inf.fu-berlin.de>
  Date:   2014-02-16 (Sun, 16 Feb 2014)

  Changed paths:
    M core/msg.c

  Log Message:
  -----------
  Merge pull request #569 from kaspar030/dont_wake_up_reply_blocked_sender_after_receive

core: msg: don't wake up sender after receive if it's REPLY_BLOCKED


Compare: https://github.com/RIOT-OS/RIOT/compare/4a3d8cddaa61...7092ac629c40


More information about the commits mailing list