[riot-commits] [RIOT-OS/RIOT] b5e746: destiny: deleting packed attribute from socket_int...

Oleg Hahm oleg at hobbykeller.org
Tue Jul 8 22:33:54 CEST 2014


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: b5e7460d459385a74be2d3b994734cc1a90f4d1c
      https://github.com/RIOT-OS/RIOT/commit/b5e7460d459385a74be2d3b994734cc1a90f4d1c
  Author: Cenk Gündoğan <cnkgndgn at gmail.com>
  Date:   2014-07-08 (Tue, 08 Jul 2014)

  Changed paths:
    M sys/net/transport_layer/destiny/socket.h

  Log Message:
  -----------
  destiny: deleting packed attribute from socket_internal_t

While testing the tcp implementation on MSBA2 I noticed that
the value of `tcp_input_buffer_end` gets changed whenever acquiring or
releasing the mutex of the struct on the server side.

After deleting the packed attribute of the struct this problem was
resolved and the value stayed the same after acquiring and releasing.

This problem could maybe arise from badly placed cache lines due to
missing padding... I am not sure.

Anyway, I guess using the packed attribute is useless here and makes it
more error-prone.


  Commit: 1518d6ac64e07c912db37c0aaf6927efd9ec276e
      https://github.com/RIOT-OS/RIOT/commit/1518d6ac64e07c912db37c0aaf6927efd9ec276e
  Author: Oleg Hahm <oleg at hobbykeller.org>
  Date:   2014-07-08 (Tue, 08 Jul 2014)

  Changed paths:
    M sys/net/transport_layer/destiny/socket.h

  Log Message:
  -----------
  Merge pull request #1390 from cgundogan/fix_socket_internal_t_packed_attr

destiny: deleting packed attribute from socket_internal_t


Compare: https://github.com/RIOT-OS/RIOT/compare/d45718909a95...1518d6ac64e0


More information about the commits mailing list