[riot-commits] [RIOT-OS/RIOT] ecf47b: destiny: using a bit field for tcp_header->data_of...

Christian Mehlis mehlis at inf.fu-berlin.de
Sat Jun 14 15:40:51 CEST 2014


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: ecf47b1f48389574a5fd6495d79b81f648f1b5bc
      https://github.com/RIOT-OS/RIOT/commit/ecf47b1f48389574a5fd6495d79b81f648f1b5bc
  Author: Cenk Gündoğan <cnkgndgn at gmail.com>
  Date:   2014-06-09 (Mon, 09 Jun 2014)

  Changed paths:
    M sys/net/include/destiny/types.h
    M sys/net/transport_layer/destiny/socket.c
    M sys/net/transport_layer/destiny/tcp.c
    M sys/net/transport_layer/destiny/tcp_hc.c

  Log Message:
  -----------
  destiny: using a bit field for tcp_header->data_offset is more convenient
In the current implementation the data offset is coded into an uint8_t.
Of this uint8_t only 3 bits apply for the data offset.
The remaining bits represent reserved flags for future use.
However, a proper bit masking is forgotten in order
to obtain the data offset part of this uint8_t.

Therefore, defining this uint8_t as a bit field allows a more convenient
method of access.


  Commit: 997dcd7e88b11bd6bb9ad96ece0caaa2e3aaa442
      https://github.com/RIOT-OS/RIOT/commit/997dcd7e88b11bd6bb9ad96ece0caaa2e3aaa442
  Author: Christian Mehlis <mehlis at inf.fu-berlin.de>
  Date:   2014-06-14 (Sat, 14 Jun 2014)

  Changed paths:
    M sys/net/include/destiny/types.h
    M sys/net/transport_layer/destiny/socket.c
    M sys/net/transport_layer/destiny/tcp.c
    M sys/net/transport_layer/destiny/tcp_hc.c

  Log Message:
  -----------
  Merge pull request #1302 from cgundogan/fix_tcp_header_data_offset

destiny: using a bit field for tcp_header->data_offset is more convenient


Compare: https://github.com/RIOT-OS/RIOT/compare/a2872cd8da0e...997dcd7e88b1


More information about the commits mailing list