[riot-commits] [RIOT-OS/RIOT] 75546f: destiny: set ack bit for (almost) all segments aft...

Oleg Hahm oleg at hobbykeller.org
Tue Jun 24 11:16:39 CEST 2014


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 75546fcf6cb4c0ab87db909367841ca72a369f05
      https://github.com/RIOT-OS/RIOT/commit/75546fcf6cb4c0ab87db909367841ca72a369f05
  Author: Cenk Gündoğan <cnkgndgn at gmail.com>
  Date:   2014-06-24 (Tue, 24 Jun 2014)

  Changed paths:
    M sys/net/transport_layer/destiny/socket.c
    M sys/net/transport_layer/destiny/socket.h
    M sys/net/transport_layer/destiny/tcp.c

  Log Message:
  -----------
  destiny: set ack bit for (almost) all segments after syn
The current implementation does not set the ack bit
for outgoing data segments and the fin segment.

However, RFC793 states that all segments
should have an ack bit set in order to present a valid
ack nr. in outgoing segments.

Currently, data segments and acknowledgement segments
are distinguished by the existence of their ack bit.
With the new assumption, that both of these types of
segments need an ack bit set, I had to change several
parts of the current implementation to make this
decision by inspecting the payload size.

destiny: added parens


  Commit: fda7ce12d2135f874cbf09e61f7b28b8e7b63289
      https://github.com/RIOT-OS/RIOT/commit/fda7ce12d2135f874cbf09e61f7b28b8e7b63289
  Author: Oleg Hahm <oleg at hobbykeller.org>
  Date:   2014-06-24 (Tue, 24 Jun 2014)

  Changed paths:
    M sys/net/transport_layer/destiny/socket.c
    M sys/net/transport_layer/destiny/socket.h
    M sys/net/transport_layer/destiny/tcp.c

  Log Message:
  -----------
  Merge pull request #1321 from cgundogan/fix_missing_ack_bit

destiny: set ack bit for (almost) all segments after syn


Compare: https://github.com/RIOT-OS/RIOT/compare/8931681e8a6c...fda7ce12d213


More information about the commits mailing list