[riot-commits] [RIOT-OS/RIOT] e71016: netdev2: function parameter type changes

Martine Lenders authmillenon at gmail.com
Fri Aug 5 14:10:14 CEST 2016


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: e710164f09524c5aa0b62c89c87c849d6989844d
      https://github.com/RIOT-OS/RIOT/commit/e710164f09524c5aa0b62c89c87c849d6989844d
  Author: Martine Lenders <mlenders at inf.fu-berlin.de>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M drivers/include/net/netdev2.h

  Log Message:
  -----------
  netdev2: function parameter type changes

`len` and `count` are both values that should never go `< 0`, so instead of
having to test this (in theory) every time the function is called (regardless
of by assert or if its unnecessary code), I propose to change it to `size_t`.

As a bonus I made the type of recv's buf parameter generic - no reason for it to
be a char and it might lead to unnecessary static casting requirements


  Commit: bd2429f29984e34c5dda0a9850466f17cd3f3777
      https://github.com/RIOT-OS/RIOT/commit/bd2429f29984e34c5dda0a9850466f17cd3f3777
  Author: Martine Lenders <mail at martine-lenders.eu>
  Date:   2016-08-03 (Wed, 03 Aug 2016)

  Changed paths:
    M cpu/cc2538/radio/cc2538_rf_netdev.c
    M cpu/native/netdev2_tap/netdev2_tap.c
    M drivers/at86rf2xx/at86rf2xx_netdev.c
    M drivers/cc110x/cc110x-netdev2.c
    M drivers/cc2420/cc2420.c
    M drivers/cc2420/cc2420_netdev.c
    M drivers/enc28j60/enc28j60.c
    M drivers/encx24j600/encx24j600.c
    M drivers/ethos/ethos.c
    M drivers/include/cc2420.h
    M sys/net/netdev2_test/netdev2_test.c
    M tests/driver_at86rf2xx/recv.c

  Log Message:
  -----------
  cpu: drivers: adapt devices for netdev2 parameter type change


  Commit: 49521dcfd90851f7aaac2981d618e1b1fdbf71da
      https://github.com/RIOT-OS/RIOT/commit/49521dcfd90851f7aaac2981d618e1b1fdbf71da
  Author: Martine Lenders <authmillenon at gmail.com>
  Date:   2016-08-05 (Fri, 05 Aug 2016)

  Changed paths:
    M cpu/cc2538/radio/cc2538_rf_netdev.c
    M cpu/native/netdev2_tap/netdev2_tap.c
    M drivers/at86rf2xx/at86rf2xx_netdev.c
    M drivers/cc110x/cc110x-netdev2.c
    M drivers/cc2420/cc2420.c
    M drivers/cc2420/cc2420_netdev.c
    M drivers/enc28j60/enc28j60.c
    M drivers/encx24j600/encx24j600.c
    M drivers/ethos/ethos.c
    M drivers/include/cc2420.h
    M drivers/include/net/netdev2.h
    M sys/net/netdev2_test/netdev2_test.c
    M tests/driver_at86rf2xx/recv.c

  Log Message:
  -----------
  Merge pull request #5495 from miri64/netdev2/enh/type-changes

netdev2: some parameter type changes


Compare: https://github.com/RIOT-OS/RIOT/compare/d58704646244...49521dcfd908


More information about the commits mailing list