[riot-commits] [RIOT-OS/RIOT] e92c35: udp: fixed a corner case for checksum computation.

Martine Lenders authmillenon at gmail.com
Mon Mar 7 09:21:24 CET 2016


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: e92c355abaf702792377fc8f3a7d64a968a46776
      https://github.com/RIOT-OS/RIOT/commit/e92c355abaf702792377fc8f3a7d64a968a46776
  Author: Yonezawa-T2 <Yonezawa-T2 at mail.dnp.co.jp>
  Date:   2016-02-22 (Mon, 22 Feb 2016)

  Changed paths:
    M sys/net/gnrc/transport_layer/udp/gnrc_udp.c
    A tests/unittests/tests-gnrc_udp/Makefile
    A tests/unittests/tests-gnrc_udp/Makefile.include
    A tests/unittests/tests-gnrc_udp/tests-gnrc_udp.c
    A tests/unittests/tests-gnrc_udp/tests-gnrc_udp.h

  Log Message:
  -----------
  udp: fixed a corner case for checksum computation.

Fixes #4842.

RFC 2460 section 8.1 (https://tools.ietf.org/html/rfc2460#section-8.1)
states:
> if that computation yields a result of zero, it must be changed to hex
> FFFF for placement in the UDP header.


  Commit: b1dd2818fe812a8182df4b448e39bcf11b4d9b93
      https://github.com/RIOT-OS/RIOT/commit/b1dd2818fe812a8182df4b448e39bcf11b4d9b93
  Author: Yonezawa-T2 <Yonezawa-T2 at mail.dnp.co.jp>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M sys/net/gnrc/transport_layer/udp/gnrc_udp.c

  Log Message:
  -----------
  udp: discard UDP packets with zero checksum.

RFC 2460 Section 8.1

> IPv6 receivers must discard UDP packets containing a zero checksum,
> and should log the error.


  Commit: cba05cc028c2ad5c58d67e5b5cf2fa8a0902d7c2
      https://github.com/RIOT-OS/RIOT/commit/cba05cc028c2ad5c58d67e5b5cf2fa8a0902d7c2
  Author: Martine Lenders <authmillenon at gmail.com>
  Date:   2016-03-07 (Mon, 07 Mar 2016)

  Changed paths:
    M sys/net/gnrc/transport_layer/udp/gnrc_udp.c
    A tests/unittests/tests-gnrc_udp/Makefile
    A tests/unittests/tests-gnrc_udp/Makefile.include
    A tests/unittests/tests-gnrc_udp/tests-gnrc_udp.c
    A tests/unittests/tests-gnrc_udp/tests-gnrc_udp.h

  Log Message:
  -----------
  Merge pull request #4873 from Yonezawa-T2/zero_udp_checksum

udp: fixed a corner case for checksum computation.


Compare: https://github.com/RIOT-OS/RIOT/compare/9201063bd1e2...cba05cc028c2


More information about the commits mailing list