[riot-commits] [RIOT-OS/RIOT] 65911f: cppcheck: Don't Run cppcheck on ASM files.

Joakim Nohlgård joakim.nohlgard at eistec.se
Thu Mar 30 09:07:13 CEST 2017


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 65911f349927e819e1ce871241f129a8696c9924
      https://github.com/RIOT-OS/RIOT/commit/65911f349927e819e1ce871241f129a8696c9924
  Author: Neil Jones <neil.jones at imgtec.com>
  Date:   2017-03-29 (Wed, 29 Mar 2017)

  Changed paths:
    M dist/tools/cppcheck/check.sh

  Log Message:
  -----------
  cppcheck: Don't Run cppcheck on ASM files.

cppcheck doesn't understand ASM style comments beginning with '#' and tries to
parse them:

I get this error:
 cpu/mips_pic32_common/reset_mod.S:84: error (syntaxError): syntax error
from this line:
 beqz s1, init_resources # Branch if this is NOT an NMI exception.

If I place the comment inside C-style comments cppcheck passes, ie

 beqz s1, init_resources # /*Branch if this is NOT an NMI exception.*/

Note current in-tree ASM files fail cppcheck (they must have been added before
this check) for example:

cpu/lpc2387/asmfunc.s


  Commit: 7f8f4b46742ccf9a512bfc03928984ad53acdc25
      https://github.com/RIOT-OS/RIOT/commit/7f8f4b46742ccf9a512bfc03928984ad53acdc25
  Author: Joakim Nohlgård <joakim.nohlgard at eistec.se>
  Date:   2017-03-30 (Thu, 30 Mar 2017)

  Changed paths:
    M dist/tools/cppcheck/check.sh

  Log Message:
  -----------
  Merge pull request #6816 from neiljay/pr/fix_cpp_check

cppcheck: Don't Run cppcheck on ASM files.


Compare: https://github.com/RIOT-OS/RIOT/compare/76bae4b111ba...7f8f4b46742c


More information about the commits mailing list