[riot-commits] [RIOT-OS/RIOT] 72e9b1: gnrc_ipv6: remove superfluous release

Gaëtan Harter hartergaetan at gmail.com
Thu Aug 2 15:40:52 CEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 72e9b1f623d6b9b625a6ee5c92e00b8c0dcce8d2
      https://github.com/RIOT-OS/RIOT/commit/72e9b1f623d6b9b625a6ee5c92e00b8c0dcce8d2
  Author: Martine Lenders <m.lenders at fu-berlin.de>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: remove superfluous release

The packet handed to `_fill_ipv6_hdr()` is already released in the
caller (in the current version this is only `_save_fill_ipv6_hdr()`).


  Commit: cb4f6a96a84b7be1ecf9b987e81866ec5056a247
      https://github.com/RIOT-OS/RIOT/commit/cb4f6a96a84b7be1ecf9b987e81866ec5056a247
  Author: Martine Lenders <m.lenders at fu-berlin.de>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: correctly reset from temporary variable

While `tmp` in the loop for write-protection for the check-sum
calculation is used to check the return value of
`gnrc_pktbuf_start_write()`, it was never overwriting `payload` causing
the original snip to be used in the following iteration `prev` when
duplicated, and destroying the sanity of `ipv6`.


  Commit: f946314837fcd45601444c2c3a8553eb6905c411
      https://github.com/RIOT-OS/RIOT/commit/f946314837fcd45601444c2c3a8553eb6905c411
  Author: Martine Lenders <mail at martine-lenders.eu>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: refactor to remove superfluous temporary variable

Since no release in this function is required anyways, we can just use
`payload` to check the return value directly.


  Commit: d5505930cc118bed05aad8ed9b369502d8979a26
      https://github.com/RIOT-OS/RIOT/commit/d5505930cc118bed05aad8ed9b369502d8979a26
  Author: Gaëtan Harter <hartergaetan at gmail.com>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  Merge pull request #9672 from miri64/gnrc_ipv6/fix/8215-regression

gnrc_ipv6: fix regression from #8215


Compare: https://github.com/RIOT-OS/RIOT/compare/7909ce527f98...d5505930cc11
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list