[riot-commits] [RIOT-OS/RIOT] 61a289: gnrc_ipv6: remove superfluous release

Gaëtan Harter hartergaetan at gmail.com
Thu Aug 2 18:23:06 CEST 2018


  Branch: refs/heads/2018.07-branch
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 61a289bbadb1fdc82b5676cdcea3bc425b881ffc
      https://github.com/RIOT-OS/RIOT/commit/61a289bbadb1fdc82b5676cdcea3bc425b881ffc
  Author: Martine Lenders <m.lenders at fu-berlin.de>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: remove superfluous release

The packet handed to `_fill_ipv6_hdr()` is already released in the
caller (in the current version this is only `_save_fill_ipv6_hdr()`).

(cherry picked from commit 72e9b1f623d6b9b625a6ee5c92e00b8c0dcce8d2)


  Commit: b8b3d755446c5b5d89004def6e3d365c876e4458
      https://github.com/RIOT-OS/RIOT/commit/b8b3d755446c5b5d89004def6e3d365c876e4458
  Author: Martine Lenders <m.lenders at fu-berlin.de>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: correctly reset from temporary variable

While `tmp` in the loop for write-protection for the check-sum
calculation is used to check the return value of
`gnrc_pktbuf_start_write()`, it was never overwriting `payload` causing
the original snip to be used in the following iteration `prev` when
duplicated, and destroying the sanity of `ipv6`.

(cherry picked from commit cb4f6a96a84b7be1ecf9b987e81866ec5056a247)


  Commit: 7826b4de0efc284fb0e9a8224a5003c6af757eed
      https://github.com/RIOT-OS/RIOT/commit/7826b4de0efc284fb0e9a8224a5003c6af757eed
  Author: Martine Lenders <mail at martine-lenders.eu>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  gnrc_ipv6: refactor to remove superfluous temporary variable

Since no release in this function is required anyways, we can just use
`payload` to check the return value directly.

(cherry picked from commit f946314837fcd45601444c2c3a8553eb6905c411)


  Commit: 20a9727d0397cbc7de94d4139c183001d23fa1e5
      https://github.com/RIOT-OS/RIOT/commit/20a9727d0397cbc7de94d4139c183001d23fa1e5
  Author: Gaëtan Harter <hartergaetan at gmail.com>
  Date:   2018-08-02 (Thu, 02 Aug 2018)

  Changed paths:
    M sys/net/gnrc/network_layer/ipv6/gnrc_ipv6.c

  Log Message:
  -----------
  Merge pull request #9684 from miri64/2018.07/gnrc_ipv6/fix/8215-regression

gnrc_ipv6: fix regression from #8215 [backport 2018.07]


Compare: https://github.com/RIOT-OS/RIOT/compare/8b9231ce591d...20a9727d0397
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list