[riot-commits] [RIOT-OS/RIOT] 18ae76: cpu/lpc2387: Fixed doc and attribute of arm_reset

Martine Lenders authmillenon at gmail.com
Tue Aug 14 16:20:56 CEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 18ae7652a99e2b0ebf1908037bf053c840df2944
      https://github.com/RIOT-OS/RIOT/commit/18ae7652a99e2b0ebf1908037bf053c840df2944
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M cpu/lpc2387/cpu.c

  Log Message:
  -----------
  cpu/lpc2387: Fixed doc and attribute of arm_reset

- arm_reset was completely undocumented, even though technical details buried
  deeply in the data sheet of the LPC2387 are involved in the code
- The attribute "naked" is misplaced, it should only be used when no C code
  is present. However, the function consists of C code only
- The attribute "noreturn" has to be used in the declaration [1] of a function,
  not in the implementation. Otherwise the caller is not informed and code using
  the function will not be optimized.

[1]: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html


  Commit: 6358e75f010def98a33dbd5799787089703c1288
      https://github.com/RIOT-OS/RIOT/commit/6358e75f010def98a33dbd5799787089703c1288
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M cpu/lpc2387/lpc23xx-iap.c

  Log Message:
  -----------
  cpu/lpc2387: Fixed bug and readability in IAP

- Previous cast was to a function pointer was not legal
- Using already present function pointer to store the IAP entry point to improve
  readability. (Which also fixes the cast issue.)


  Commit: f31375a1527dc7dc0982dcce7cd15bf7d9ef9c2f
      https://github.com/RIOT-OS/RIOT/commit/f31375a1527dc7dc0982dcce7cd15bf7d9ef9c2f
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M cpu/lpc2387/mci/lpc2387-mci.c

  Log Message:
  -----------
  cpu/lpc2387: Use PRIu32 in DEBUG() in mci


  Commit: e7b554bad2ef2a3217db759108724121d71834dd
      https://github.com/RIOT-OS/RIOT/commit/e7b554bad2ef2a3217db759108724121d71834dd
  Author: Martine Lenders <authmillenon at gmail.com>
  Date:   2018-08-14 (Tue, 14 Aug 2018)

  Changed paths:
    M cpu/lpc2387/cpu.c
    M cpu/lpc2387/lpc23xx-iap.c
    M cpu/lpc2387/mci/lpc2387-mci.c

  Log Message:
  -----------
  Merge pull request #9773 from maribu/lpc2387

cpu/lpc2387: Fixed documentation and bugs preventing use of LLVM


Compare: https://github.com/RIOT-OS/RIOT/compare/56d79b3aeaf6...e7b554bad2ef
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list