[riot-commits] [RIOT-OS/RIOT] f0e785: crypto/ccm: check ccm_compute_adata_mac return val...

Koen Zandberg koen at bergzand.net
Mon Nov 12 17:30:19 CET 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: f0e785a43071bb45a7c50c5da0bf7d8e76c9c074
      https://github.com/RIOT-OS/RIOT/commit/f0e785a43071bb45a7c50c5da0bf7d8e76c9c074
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c

  Log Message:
  -----------
  crypto/ccm: check ccm_compute_adata_mac return value

Return value was ignored but function could fail


  Commit: 3fd8276c37bae159d404f14d57f8e52d68c1cd43
      https://github.com/RIOT-OS/RIOT/commit/3fd8276c37bae159d404f14d57f8e52d68c1cd43
  Author: Wentao Shang <wentaoshang at gmail.com>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c

  Log Message:
  -----------
  crypto/ccm: fix auth_data_len upperbound value

RFC3610 states that len_encoding is only valid for "0x0001 ... 0xFEFF"

   If 0 < l(a) < (2^16 - 2^8), then the length field is encoded as two
   octets which contain the value l(a) in most-significant-byte first
   order.


  Commit: 147390c2093b0b010e9b53fbb984362148f26f7b
      https://github.com/RIOT-OS/RIOT/commit/147390c2093b0b010e9b53fbb984362148f26f7b
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M tests/unittests/tests-crypto/tests-crypto-modes-ccm.c

  Log Message:
  -----------
  tests/ccm: add test for auth_data_len upper value

Maximal supported value is 0xFEFF.


  Commit: 00b6e46abcd4aa7bc7cc838c861c9d7618a9c643
      https://github.com/RIOT-OS/RIOT/commit/00b6e46abcd4aa7bc7cc838c861c9d7618a9c643
  Author: Koen Zandberg <koen at bergzand.net>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c
    M tests/unittests/tests-crypto/tests-crypto-modes-ccm.c

  Log Message:
  -----------
  Merge pull request #8114 from cladmi/pr/crypto/ccm/auth_data_len_upper_bound

crypto/ccm: fix auth_data_len check


Compare: https://github.com/RIOT-OS/RIOT/compare/685efc4f5d9c...00b6e46abcd4
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list