[riot-commits] [RIOT-OS/RIOT] 127d0a: crypto/ccm: check ccm_compute_adata_mac return val...

José Alamos jialamos at uc.cl
Mon Nov 12 20:51:28 CET 2018


  Branch: refs/heads/2018.10-branch
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 127d0a36dae2e5358119ae5a051404fbf348aebf
      https://github.com/RIOT-OS/RIOT/commit/127d0a36dae2e5358119ae5a051404fbf348aebf
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c

  Log Message:
  -----------
  crypto/ccm: check ccm_compute_adata_mac return value

Return value was ignored but function could fail

(cherry picked from commit f0e785a43071bb45a7c50c5da0bf7d8e76c9c074)


  Commit: 75623d6ae164438e2b1ffb8200bead530472c6d9
      https://github.com/RIOT-OS/RIOT/commit/75623d6ae164438e2b1ffb8200bead530472c6d9
  Author: Wentao Shang <wentaoshang at gmail.com>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c

  Log Message:
  -----------
  crypto/ccm: fix auth_data_len upperbound value

RFC3610 states that len_encoding is only valid for "0x0001 ... 0xFEFF"

   If 0 < l(a) < (2^16 - 2^8), then the length field is encoded as two
   octets which contain the value l(a) in most-significant-byte first
   order.

(cherry picked from commit 3fd8276c37bae159d404f14d57f8e52d68c1cd43)


  Commit: c9478153fe0e9036f49d43a442c541f205604e69
      https://github.com/RIOT-OS/RIOT/commit/c9478153fe0e9036f49d43a442c541f205604e69
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M tests/unittests/tests-crypto/tests-crypto-modes-ccm.c

  Log Message:
  -----------
  tests/ccm: add test for auth_data_len upper value

Maximal supported value is 0xFEFF.

(cherry picked from commit 147390c2093b0b010e9b53fbb984362148f26f7b)


  Commit: 4c810c20963f55d28d4f4002913509e58f2a18c9
      https://github.com/RIOT-OS/RIOT/commit/4c810c20963f55d28d4f4002913509e58f2a18c9
  Author: José Alamos <jialamos at uc.cl>
  Date:   2018-11-12 (Mon, 12 Nov 2018)

  Changed paths:
    M sys/crypto/modes/ccm.c
    M tests/unittests/tests-crypto/tests-crypto-modes-ccm.c

  Log Message:
  -----------
  Merge pull request #10377 from cladmi/backport/2018.10/pr/crypto/ccm/auth_data_len_upper_bound

crypto/ccm: fix auth_data_len check [backport 2018.10]


Compare: https://github.com/RIOT-OS/RIOT/compare/3ff78e1ee097...4c810c20963f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list