[riot-commits] [RIOT-OS/RIOT] c4ccae: boards/msba2: Do not set PORT.

Martine Lenders authmillenon at gmail.com
Wed Nov 28 16:43:25 CET 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: c4ccaecda5443cb91da8b18cf04d654e31882368
      https://github.com/RIOT-OS/RIOT/commit/c4ccaecda5443cb91da8b18cf04d654e31882368
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M boards/common/msba2/Makefile.include

  Log Message:
  -----------
  boards/msba2: Do not set PORT.

Boards should not set PORT and should not have code conditional on
PORT as that causes PORT to be evaluated and the build to fail even
if this varible is not needed.

Exporting has the same effect.

This fixes the MSBA2 board by declaring PORT_LINUX and PORT_DARWIN
instead.


  Commit: 4b06d64778df5067a1529152f1a66c729cc0eee5
      https://github.com/RIOT-OS/RIOT/commit/4b06d64778df5067a1529152f1a66c729cc0eee5
  Author: Martine Lenders <authmillenon at gmail.com>
  Date:   2018-11-28 (Wed, 28 Nov 2018)

  Changed paths:
    M boards/common/msba2/Makefile.include

  Log Message:
  -----------
  Merge pull request #10454 from jcarrano/msba2-fix-port

boards/msba2: Do not set PORT.


Compare: https://github.com/RIOT-OS/RIOT/compare/061e32bad071...4b06d64778df
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list