[riot-commits] [RIOT-OS/RIOT] 2ffb83: pkg/nimble: add patch to fix pointer alignment iss...

Sebastian Meiling s at mlng.net
Fri Nov 30 09:32:40 CET 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 2ffb83af6f17bf621c364dcec4e721cde4d0bb60
      https://github.com/RIOT-OS/RIOT/commit/2ffb83af6f17bf621c364dcec4e721cde4d0bb60
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2018-11-29 (Thu, 29 Nov 2018)

  Changed paths:
    M pkg/nimble/Makefile
    A pkg/nimble/patches/0001-L2CAP-sm-do-not-discard-alignment-information.patch

  Log Message:
  -----------
  pkg/nimble: add patch to fix pointer alignment issue.

Nimble contains a couple of casts that discard alignment information.
This causes a warning with clang's -Wno-address-of-packed-member.

A previous PR (#10503) supressed that warning. This commit re-enables
them and provides a patch to fix the offending code.

The fix has been submitted upstream, see
https://github.com/apache/mynewt-nimble/pull/252


  Commit: d7789c08f2ea28591a9011580d2c850edfeb62b5
      https://github.com/RIOT-OS/RIOT/commit/d7789c08f2ea28591a9011580d2c850edfeb62b5
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2018-11-29 (Thu, 29 Nov 2018)

  Changed paths:
    M pkg/nimble/Makefile

  Log Message:
  -----------
  nimble/Makefile: remove unnecessary warning suppression.

The -Wno-sometimes-uninitialized suppression seems to no longer be
necessary. Removing it as it may mask a real bug.

If the problem reappears, and if the comment is correct about it
being only in an unused function, then instead of adding the CFLAG,
it should be fixed locally via a patch.


  Commit: 297aa4eb9b2a86903db507ac0bedad976a18dfaf
      https://github.com/RIOT-OS/RIOT/commit/297aa4eb9b2a86903db507ac0bedad976a18dfaf
  Author: Sebastian Meiling <s at mlng.net>
  Date:   2018-11-30 (Fri, 30 Nov 2018)

  Changed paths:
    M pkg/nimble/Makefile
    A pkg/nimble/patches/0001-L2CAP-sm-do-not-discard-alignment-information.patch

  Log Message:
  -----------
  Merge pull request #10511 from jcarrano/nimble-slowfix

 pkg/nimble: Remove warning suppressions, add patches


Compare: https://github.com/RIOT-OS/RIOT/compare/5794a2283e51...297aa4eb9b2a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list