[riot-commits] [RIOT-OS/RIOT] 59e299: cppcheck: add/correct reason for cppcheck-suppress

Martine Lenders authmillenon at gmail.com
Tue Sep 25 13:52:30 CEST 2018


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 59e299635b34d2e572ec6773573ae4efccd7597d
      https://github.com/RIOT-OS/RIOT/commit/59e299635b34d2e572ec6773573ae4efccd7597d
  Author: smlng <s at mlng.net>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M core/clist.c
    M cpu/cortexm_common/vectors_cortexm.c
    M cpu/fe310/periph/uart.c
    M cpu/kinetis/periph/i2c.c
    M cpu/kinetis/periph/timer.c
    M cpu/mips32r2_common/newlib_syscalls_mips_uhi/syscalls.c
    M dist/tools/tunslip/tunslip6.c
    M drivers/adt7310/adt7310.c
    M sys/net/gnrc/transport_layer/tcp/gnrc_tcp_eventloop.c
    M sys/net/gnrc/transport_layer/tcp/gnrc_tcp_fsm.c
    M sys/quad_math/qdivrem.c
    M sys/universal_address/universal_address.c
    M tests/buttons/main.c
    M tests/cpp11_condition_variable/main.cpp
    M tests/leds/main.c

  Log Message:
  -----------
  cppcheck: add/correct reason for cppcheck-suppress

Adding and correcting description/rational on why certain cppcheck
warnings or errors are intentionally suppressed.


  Commit: 3f811c44dbdc1cbfb7d8cdc53fd66607523bff54
      https://github.com/RIOT-OS/RIOT/commit/3f811c44dbdc1cbfb7d8cdc53fd66607523bff54
  Author: smlng <s at mlng.net>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M dist/tools/cppcheck/README.md

  Log Message:
  -----------
  cppcheck: extend cppcheck README example

Extend the cppcheck suppression example to show that each suppression
should have a reason describing the intentional suppression of a
cppcheck warning or error.


  Commit: d7942cd974f813519933b162bc5594ddf5f28454
      https://github.com/RIOT-OS/RIOT/commit/d7942cd974f813519933b162bc5594ddf5f28454
  Author: smlng <s at mlng.net>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M dist/tools/tunslip/tunslip6.c

  Log Message:
  -----------
  dist/tools: fix tunslip6 strncat num param

Cppcheck was (correctly) warning here that concat to strings might
result in buffer overflow because the terminating `\0` was not considered.
This is fixed here, making the cppcheck suppression also obsolete.


  Commit: 5b1cd0475f2de80e78795c1253a15be3f6399f38
      https://github.com/RIOT-OS/RIOT/commit/5b1cd0475f2de80e78795c1253a15be3f6399f38
  Author: smlng <s at mlng.net>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M core/clist.c

  Log Message:
  -----------
  core/clist: add cppcheck-suppress nullPointer

This was found by cppcheck 1.6x used in Travis-CI, however this
seems to be a false positive, as it is not found by newer versions
of cppcheck.


  Commit: 5ac02f513461ac55e55bd5c719299198211e92b1
      https://github.com/RIOT-OS/RIOT/commit/5ac02f513461ac55e55bd5c719299198211e92b1
  Author: Martine Lenders <authmillenon at gmail.com>
  Date:   2018-09-25 (Tue, 25 Sep 2018)

  Changed paths:
    M core/clist.c
    M cpu/cortexm_common/vectors_cortexm.c
    M cpu/fe310/periph/uart.c
    M cpu/kinetis/periph/i2c.c
    M cpu/kinetis/periph/timer.c
    M cpu/mips32r2_common/newlib_syscalls_mips_uhi/syscalls.c
    M dist/tools/cppcheck/README.md
    M dist/tools/tunslip/tunslip6.c
    M drivers/adt7310/adt7310.c
    M sys/net/gnrc/transport_layer/tcp/gnrc_tcp_eventloop.c
    M sys/net/gnrc/transport_layer/tcp/gnrc_tcp_fsm.c
    M sys/quad_math/qdivrem.c
    M sys/universal_address/universal_address.c
    M tests/buttons/main.c
    M tests/cpp11_condition_variable/main.cpp
    M tests/leds/main.c

  Log Message:
  -----------
  Merge pull request #10010 from smlng/pr/fix/cppcheck-suppress

dist/cppcheck: fix missing cppcheck-suppression reasons


Compare: https://github.com/RIOT-OS/RIOT/compare/1ff945311bf7...5ac02f513461
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list