[riot-commits] [RIOT-OS/RIOT] 9926ac: ci/print_toolchain_versions: robust/portable versi...

Sebastian Meiling noreply at github.com
Wed Aug 14 11:11:54 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 9926ac1ffaad18e259ca1b20f84a446fcc1738c2
      https://github.com/RIOT-OS/RIOT/commit/9926ac1ffaad18e259ca1b20f84a446fcc1738c2
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M dist/tools/ci/print_toolchain_versions.sh

  Log Message:
  -----------
  ci/print_toolchain_versions: robust/portable version detection.

Detect command line tool versions without using "command".
Command may be a builting in some shells, leading to unportability.

The new version uses the status code to correctly detect a non-existent
command. This allows it to differentiate between error in the tool and
not-found errors.

It also works with compound commands, for example `python -m callable_module".


  Commit: 2209435214a64d0e5bcead6b5150fd333673a74b
      https://github.com/RIOT-OS/RIOT/commit/2209435214a64d0e5bcead6b5150fd333673a74b
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-01-15 (Tue, 15 Jan 2019)

  Changed paths:
    M dist/tools/ci/print_toolchain_versions.sh

  Log Message:
  -----------
  tools/ci: correcly report flake8 version.

If the flake8 executable is not found, the static test script reports
the tool as missing. It may happen that the flake8 module is installed,
but the console entry point is not.

In the flake8 shell script, flake is invoked via `python -m`. The result
is a confusing error message where static-test reports the tools as missing,
yet the flake8 tests are run.

This patch makes the toolchain version script use the same command as the
flake8 script.


  Commit: 950b83e63e8310ac1e94be360d826ea701bee60e
      https://github.com/RIOT-OS/RIOT/commit/950b83e63e8310ac1e94be360d826ea701bee60e
  Author: Sebastian Meiling <s at mlng.net>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M dist/tools/ci/print_toolchain_versions.sh

  Log Message:
  -----------
  Merge pull request #10252 from jcarrano/flake8-report-existence

tools/ci: correcly report flake8 version.


Compare: https://github.com/RIOT-OS/RIOT/compare/c225636966df...950b83e63e83


More information about the commits mailing list