[riot-commits] [RIOT-OS/RIOT] a04800: makefiles/buildtest: add a buildtest-indocker

Francisco noreply at github.com
Wed Aug 14 17:53:21 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: a048001e96811e681e5cc5087ea1f97eb0e588c0
      https://github.com/RIOT-OS/RIOT/commit/a048001e96811e681e5cc5087ea1f97eb0e588c0
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M Makefile.include
    M makefiles/buildtests.inc.mk
    M makefiles/docker.inc.mk

  Log Message:
  -----------
  makefiles/buildtest: add a buildtest-indocker

Add a 'buildtest-indocker' that forces executing 'buildtest' for loop
completely inside the container.
It prevents starting one container per compilation wich is slower but
it could hide errors where the host toolchain would be used

It is currently equivalent to `buildtest` but will change when the
`buidtest` handling will be move outside of `BUILD_IN_DOCKER`.

Display an error when executed without BUILD_IN_DOCKER=1.


  Commit: 7d10da832a1dab0ac9111bc23a957996419ebde9
      https://github.com/RIOT-OS/RIOT/commit/7d10da832a1dab0ac9111bc23a957996419ebde9
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M makefiles/buildtests.inc.mk
    M makefiles/docker.inc.mk

  Log Message:
  -----------
  makefiles/buildtest: always execute 'buildtest' loop on host machine

This remove executing buildtest `for` loop in docker.

When building completely in docker, 'buildtest' would hide issues when
the host toolchain would be used when doing `make all` directly.
It has the consequence that it now starts a container for each
compilation which is slower.

The previous behavior can be reproduced by using

    BUILD_IN_DOCKER=1 make buildtest-indocker

A side effect is also that now `BUILDTEST_MAKE_REDIRECT` would work when
doing `buildtest` with docker.


  Commit: 3e753834e793928d2ee0946c25d6bd1232ad69c6
      https://github.com/RIOT-OS/RIOT/commit/3e753834e793928d2ee0946c25d6bd1232ad69c6
  Author: Francisco <francois-xavier.molina at inria.fr>
  Date:   2019-08-14 (Wed, 14 Aug 2019)

  Changed paths:
    M Makefile.include
    M makefiles/buildtests.inc.mk
    M makefiles/docker.inc.mk

  Log Message:
  -----------
  Merge pull request #11857 from cladmi/pr/make/buildtest/docker

makefiles/buildtest: always execute 'buildtest' loop on host machine


Compare: https://github.com/RIOT-OS/RIOT/compare/414df99a4c83...3e753834e793


More information about the commits mailing list