[riot-commits] [RIOT-OS/RIOT] cdfece: tests/shell: Use socat as the RIOT_TERMINAL.

Kaspar Schleiser noreply at github.com
Fri Aug 16 13:00:36 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: cdfece682f5c38d399ba44b8ee162b67f80bcdd8
      https://github.com/RIOT-OS/RIOT/commit/cdfece682f5c38d399ba44b8ee162b67f80bcdd8
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-08-15 (Thu, 15 Aug 2019)

  Changed paths:
    M tests/shell/Makefile

  Log Message:
  -----------
  tests/shell: Use socat as the RIOT_TERMINAL.

For test scripts, a terminal that does not modify the input and output
streams, configured without local echo, is preferred as it ensures the
test setup is introducing as little noise as possible.


  Commit: fa9337d73cc27ae35639cab6fbb82aa2f918d3ca
      https://github.com/RIOT-OS/RIOT/commit/fa9337d73cc27ae35639cab6fbb82aa2f918d3ca
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-08-15 (Thu, 15 Aug 2019)

  Changed paths:
    M sys/shell/shell.c

  Log Message:
  -----------
  sys/shell: cancel current line on CTRL-C.

CTRL-C cancels the current line, similar to how getty works.

This is useful if one is using a dumb terminal to communicate with
a node, as it saves having to repeatedly type backspace to discard the
current line. It also helps when connecting to an already running node,
as one does not know what is on the line buffer, the safest thing to do
is to begin by sending a ctrl-C.

This is a suggestion of @benemorius.


  Commit: 3f46863426ebd04e1dcb0b3bb6724e7bfe0e6caf
      https://github.com/RIOT-OS/RIOT/commit/3f46863426ebd04e1dcb0b3bb6724e7bfe0e6caf
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-08-15 (Thu, 15 Aug 2019)

  Changed paths:
    M tests/shell/tests/01-run.py

  Log Message:
  -----------
  tests/shell: use tuple instead of dictionary in test scripts.

Python dictionaries are not guaranteed to be ordered until version
3.7. In 3.6 they are ordered too, but that is an implementation
detail. riotdocker seems to be using 3.5.

As it stands now, it would not be a problem if the test commands
are run in a random order, except that:

- It would result in non-reproduceable tests.
- It hinders testing other functionality, such as exiting the shell.


  Commit: 2946f4b192dbf7e34687703cf8c8a96021c78e9f
      https://github.com/RIOT-OS/RIOT/commit/2946f4b192dbf7e34687703cf8c8a96021c78e9f
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-08-15 (Thu, 15 Aug 2019)

  Changed paths:
    M tests/shell/tests/01-run.py

  Log Message:
  -----------
  tests/shell: Test cancelling a line with ctrl-C.

Send garbage, cancel it and issue a valid command. No errors should
ocurr.


  Commit: 913614ef048c7289abf9f648c4b036677922375b
      https://github.com/RIOT-OS/RIOT/commit/913614ef048c7289abf9f648c4b036677922375b
  Author: Kaspar Schleiser <kaspar at schleiser.de>
  Date:   2019-08-16 (Fri, 16 Aug 2019)

  Changed paths:
    M sys/shell/shell.c
    M tests/shell/Makefile
    M tests/shell/tests/01-run.py

  Log Message:
  -----------
  Merge pull request #11004 from jcarrano/shell_cancel_line_ctrl-c

 sys/shell: cancel current line on CTRL-C.


Compare: https://github.com/RIOT-OS/RIOT/compare/226ace7bb6ef...913614ef048c


More information about the commits mailing list