[riot-commits] [RIOT-OS/RIOT] e14e6e: drivers/periph_common/i2c: Add not supported codes

Leandro Lanzieri leandro.lanzieri at haw-hamburg.de
Wed Jan 16 11:07:13 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: e14e6ead92c3ae6abf180dd7d82bcea1fc9059a5
      https://github.com/RIOT-OS/RIOT/commit/e14e6ead92c3ae6abf180dd7d82bcea1fc9059a5
  Author: MrKevinWeiss <weiss.kevin604 at gmail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M drivers/periph_common/i2c.c

  Log Message:
  -----------
  drivers/periph_common/i2c: Add not supported codes

This commit returns accurate error codes and prevents improper i2c states.
If since i2c_read_reg and i2c_write_reg are full frames the I2C_NOSTOP/START commands should not be supported


  Commit: 0ad94e1b4b14ce682b19b69d34480801b2933384
      https://github.com/RIOT-OS/RIOT/commit/0ad94e1b4b14ce682b19b69d34480801b2933384
  Author: MrKevinWeiss <weiss.kevin604 at gmail.com>
  Date:   2018-12-10 (Mon, 10 Dec 2018)

  Changed paths:
    M drivers/include/periph/i2c.h

  Log Message:
  -----------
  drivers/include/i2c: Fix API documentation

The write_reg/s states a repeated start write is used but that is not how the i2c is implemeneted.
Most devices also only use a continuous write so the API should be changed to match implementation and the majority of sensors.


  Commit: d9be2491441c51f7945dbfd0d7fb77e7cbc60bea
      https://github.com/RIOT-OS/RIOT/commit/d9be2491441c51f7945dbfd0d7fb77e7cbc60bea
  Author: Leandro Lanzieri <leandro.lanzieri at haw-hamburg.de>
  Date:   2019-01-16 (Wed, 16 Jan 2019)

  Changed paths:
    M drivers/include/periph/i2c.h
    M drivers/periph_common/i2c.c

  Log Message:
  -----------
  Merge pull request #10578 from MrKevinWeiss/pr/i2capi

 drivers/i2c: Fix i2c api issues


Compare: https://github.com/RIOT-OS/RIOT/compare/2fde8335c950...d9be2491441c
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list