[riot-commits] [RIOT-OS/RIOT] be75f7: makefiles/vars.inc.mk: do not export LINKFLAGS

Alexandre Abadie alexandre.abadie at inria.fr
Wed Jan 23 19:42:35 CET 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: be75f734d1ea6d27e33bb5fbf7ab2e4f664c4f5e
      https://github.com/RIOT-OS/RIOT/commit/be75f734d1ea6d27e33bb5fbf7ab2e4f664c4f5e
  Author: Gaƫtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M makefiles/vars.inc.mk

  Log Message:
  -----------
  makefiles/vars.inc.mk: do not export LINKFLAGS

It is only used by `Makefile.include` and should not be used by sub-make
instances.

This is required to prevent evaluating `LINKFLAGS` when not needed and a
required step to not evaluate it on the host with for example `avr-ld`
when building in docker.

I checked usage with:

    git grep -e '(LINKFLAGS)' -e '{LINKFLAGS}'

Packages may be using it but `LINKFLAGS` is a RIOT way of naming
things and even if `generate-xcompile-toolchain` uses `LINK` it does not
use `LINKFLAGS`.


  Commit: 3a1a615cf73085c10819a1fe3e767c2920e8a8eb
      https://github.com/RIOT-OS/RIOT/commit/3a1a615cf73085c10819a1fe3e767c2920e8a8eb
  Author: Alexandre Abadie <alexandre.abadie at inria.fr>
  Date:   2019-01-23 (Wed, 23 Jan 2019)

  Changed paths:
    M makefiles/vars.inc.mk

  Log Message:
  -----------
  Merge pull request #10853 from cladmi/pr/make/unexport/linkflags

makefiles/vars.inc.mk: do not export LINKFLAGS


Compare: https://github.com/RIOT-OS/RIOT/compare/3974c4607afe...3a1a615cf730
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the commits mailing list