[riot-commits] [RIOT-OS/RIOT] 700b5f: makefiles: Update FEATURES_OPTIONAL meaning

Francisco noreply at github.com
Fri Jun 14 18:03:27 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 700b5fb835f05fe378967177b9ea52ecba09c5a6
      https://github.com/RIOT-OS/RIOT/commit/700b5fb835f05fe378967177b9ea52ecba09c5a6
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-05-28 (Tue, 28 May 2019)

  Changed paths:
    M Makefile.dep
    M Makefile.include
    M makefiles/info-global.inc.mk
    M makefiles/info.inc.mk

  Log Message:
  -----------
  makefiles: Update FEATURES_OPTIONAL meaning

Update the FEATURES_OPTIONAL meaning to be more in line since
FEATURES_USED is defined. Handle FEATURES_OPTIONAL as a configuration from
the BSP/build that should not be changed anymore after.

`FEATURES_OPTIONAL` are by definition optional so are not supposed to
cause a build to fail.
Only the 'REQUIRED' ones that are not 'PROVIDED' are 'MISSING'.

* Do not change FEATURES_OPTIONAL to remove REQUIRED features
  * Prepare for having a different variable for the previous value
* Update dependency resolution/info-build as FEATURES_OPTIONAL cannot be missing


  Commit: e1c60ead36511a00c7db97c7379d6beb3b7bbe8a
      https://github.com/RIOT-OS/RIOT/commit/e1c60ead36511a00c7db97c7379d6beb3b7bbe8a
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-05-28 (Tue, 28 May 2019)

  Changed paths:
    M Makefile.features
    M Makefile.include
    M makefiles/info-global.inc.mk
    M makefiles/info.inc.mk

  Log Message:
  -----------
  Makefile.features: declare FEATURES_MISSING and make use of it

Put the definition of `FEATURES_MISSING` in common and use the variable
instead of duplicating code.


  Commit: 9cccc302622f42bd711383699c3d51c369ca8f8b
      https://github.com/RIOT-OS/RIOT/commit/9cccc302622f42bd711383699c3d51c369ca8f8b
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-05-28 (Tue, 28 May 2019)

  Changed paths:
    M Makefile.dep
    M Makefile.features
    M makefiles/info.inc.mk

  Log Message:
  -----------
  Makefile.features: declare FEATURES_USED and make use of it

Put the definition of `FEATURES_USED` in common and use the variable
instead of duplicating code.

This required defining 'FEATURES_OPTIONAL_ONLY|USED' to not overwrite
the value of 'FEATURES_OPTIONAL' as was done before.

Also add 'FEATURES_OPTIONAL_MISSING' to list optional features that were
not included as not provided.

This removes the need to print FEATURES_MISSING with the optional
features too.


  Commit: 6d7a70b16b32d42df9ecee4fadc20d179b1a341c
      https://github.com/RIOT-OS/RIOT/commit/6d7a70b16b32d42df9ecee4fadc20d179b1a341c
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-05-28 (Tue, 28 May 2019)

  Changed paths:
    M Makefile.features
    M Makefile.include
    M makefiles/info.inc.mk

  Log Message:
  -----------
  Makefile.features: declare FEATURES_CONFLICTING and make use of it

Define a variable for used features that conflict and use it in
`Makefie.include`.

It was not used by `info-global.inc.mk` and is still currently not.


  Commit: ff317f2221b328c37eaa95541ba81ce9600d2ad4
      https://github.com/RIOT-OS/RIOT/commit/ff317f2221b328c37eaa95541ba81ce9600d2ad4
  Author: Francisco <femolina at uc.cl>
  Date:   2019-06-14 (Fri, 14 Jun 2019)

  Changed paths:
    M Makefile.dep
    M Makefile.features
    M Makefile.include
    M makefiles/info-global.inc.mk
    M makefiles/info.inc.mk

  Log Message:
  -----------
  Merge pull request #11492 from cladmi/pr/features/declarative

Makefile.features: add declarative FEATURES_ variables definition


Compare: https://github.com/RIOT-OS/RIOT/compare/18bb31c38ef7...ff317f2221b3


More information about the commits mailing list