[riot-commits] [RIOT-OS/RIOT] 6419a7: cpu/kinetis/i2c: Fix false positive for expected E...

Sebastian Meiling noreply at github.com
Fri Jun 21 13:18:28 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 6419a7a3aac4632b70dcf623e6099628a29d6826
      https://github.com/RIOT-OS/RIOT/commit/6419a7a3aac4632b70dcf623e6099628a29d6826
  Author: MrKevinWeiss <weiss.kevin604 at gmail.com>
  Date:   2019-06-20 (Thu, 20 Jun 2019)

  Changed paths:
    M cpu/kinetis/periph/i2c.c

  Log Message:
  -----------
  cpu/kinetis/i2c: Fix false positive for expected EIO during i2c write

This fixes the positive result when master write data is NACKed.
This false positive occurs when the write frame is finished but a data nack occurred.
The AF check should occur first.


  Commit: ec62f1cccee4ff2ca53ba5ba33724a98ff183ce7
      https://github.com/RIOT-OS/RIOT/commit/ec62f1cccee4ff2ca53ba5ba33724a98ff183ce7
  Author: MrKevinWeiss <weiss.kevin604 at gmail.com>
  Date:   2019-06-21 (Fri, 21 Jun 2019)

  Changed paths:
    M cpu/kinetis/periph/i2c.c

  Log Message:
  -----------
  cpu/kinetis/i2c: Suppress cppcheck unreadVariable warning

On cppcheck 1.82 it throws a warning.
Since it costs cycles and does nothing the ++dummy is (void)dummy.
A warning suppression is added so the CI is happy.


  Commit: 7fa201ef24f9c9740e89e8f36e61e01f2605ace0
      https://github.com/RIOT-OS/RIOT/commit/7fa201ef24f9c9740e89e8f36e61e01f2605ace0
  Author: Sebastian Meiling <s at mlng.net>
  Date:   2019-06-21 (Fri, 21 Jun 2019)

  Changed paths:
    M cpu/kinetis/periph/i2c.c

  Log Message:
  -----------
  Merge pull request #11729 from MrKevinWeiss/pr/kinetis/i2c/errorcodefix

cpu/kinetis/i2c: Fix false positive for expected EIO during i2c write


Compare: https://github.com/RIOT-OS/RIOT/compare/a290f2d66c56...7fa201ef24f9


More information about the commits mailing list