[riot-commits] [RIOT-OS/RIOT] 55eccb: pkg/oonf_api: Use MRI script to combine archives.

benpicco noreply at github.com
Mon Sep 9 19:48:46 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 55eccb689feb2458b969d56ce542b1bfee3378b8
      https://github.com/RIOT-OS/RIOT/commit/55eccb689feb2458b969d56ce542b1bfee3378b8
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-09-02 (Mon, 02 Sep 2019)

  Changed paths:
    M pkg/oonf_api/Makefile

  Log Message:
  -----------
  pkg/oonf_api: Use MRI script to combine archives.

The OONF package is combining multiple ".a" file into a single archive. The
way it was being done involved creating and changing directories, unpacking
the original archives and repacking them into a combined one.

Theis has a couple of issues:

- It is untidy and wasteful.
- It breaks when thin archives are enabled, as a thin archive cannot be
  unpacked.

This commit uses a MRI script to do the combining step. It works both with
and without thin archives and is cleaner overall.

An issue that remains to be soved is that make is calling itself to create the
archive, as the PARTIAL_ARCHIVES are not known before hand. This is hacky. It
can be solved but it is a subject for another PR.


  Commit: 4e4414da611d43b72d8bc3cb087b9d7958a2180f
      https://github.com/RIOT-OS/RIOT/commit/4e4414da611d43b72d8bc3cb087b9d7958a2180f
  Author: benpicco <benpicco at googlemail.com>
  Date:   2019-09-09 (Mon, 09 Sep 2019)

  Changed paths:
    M pkg/oonf_api/Makefile

  Log Message:
  -----------
  Merge pull request #12155 from jcarrano/oonf-mri-combine-archives

pkg/oonf_api: Use MRI script to combine archives.


Compare: https://github.com/RIOT-OS/RIOT/compare/88e07c06d295...4e4414da611d


More information about the commits mailing list