[riot-commits] [RIOT-OS/RIOT] c103b3: serial: Do not export PORT.

Francisco noreply at github.com
Thu Sep 12 13:50:26 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: c103b3f6baf38ec4f04f0732f286d44841bb6701
      https://github.com/RIOT-OS/RIOT/commit/c103b3f6baf38ec4f04f0732f286d44841bb6701
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-06-03 (Mon, 03 Jun 2019)

  Changed paths:
    M boards/native/Makefile.include
    M makefiles/tools/serial.inc.mk
    M makefiles/vars.inc.mk

  Log Message:
  -----------
  serial: Do not export PORT.

This variable is only used for the term recipe (and maybe for flashing). They
should not be evaluated if they are not needed and the user should not see a
warning that the port is not set if he does not use port (for example in make
all.)


  Commit: 7f1357b721dfc025ee9b012eba1ce5286867d12e
      https://github.com/RIOT-OS/RIOT/commit/7f1357b721dfc025ee9b012eba1ce5286867d12e
  Author: Juan Carrano <j.carrano at fu-berlin.de>
  Date:   2019-06-03 (Mon, 03 Jun 2019)

  Changed paths:
    M dist/tools/usb-serial/README.md

  Log Message:
  -----------
  tools/usb-serial: do not advise people to export PORT.

The example in the tool documentation contains several things that are
wrong:

- exports PORT.
- Defines the port using :=.
- Defines PORT instead of PORT_LINUX, PORT_DARWIN
- ifeq-based logic (which will force an evaluation).

I have not tested the new example script.


  Commit: 2d890db6af240cdc9431e713e4717bc6b5a861bb
      https://github.com/RIOT-OS/RIOT/commit/2d890db6af240cdc9431e713e4717bc6b5a861bb
  Author: Francisco <francois-xavier.molina at inria.fr>
  Date:   2019-09-12 (Thu, 12 Sep 2019)

  Changed paths:
    M boards/native/Makefile.include
    M dist/tools/usb-serial/README.md
    M makefiles/tools/serial.inc.mk
    M makefiles/vars.inc.mk

  Log Message:
  -----------
  Merge pull request #10440 from jcarrano/no-export-ports

makefiles: remove exports so that PORT is not evaluated if it's not needed.


Compare: https://github.com/RIOT-OS/RIOT/compare/c2627706348c...2d890db6af24


More information about the commits mailing list