[riot-commits] [RIOT-OS/RIOT] a581c2: Makefile.base: implement relative path linking wit...

benpicco noreply at github.com
Mon Sep 16 17:05:54 CEST 2019


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: a581c2c8ce52427316137e03b8dc1832b9c14561
      https://github.com/RIOT-OS/RIOT/commit/a581c2c8ce52427316137e03b8dc1832b9c14561
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M Makefile.base

  Log Message:
  -----------
  Makefile.base: implement relative path linking without 'realpath'

This fixes the following issues:

* Use of 'realpath' not supported on mac
* Call of 'realpath' once for each file instead of one per archive
* Do not trigger 'llvm-ar' bug when invoked in the object directory.
    llvm-ar rcTs ../m.a obj.o  # Bugged
    llvm-ar rcTs m.a m/obj.o   # working

Using relative path linking is required to have a valid thin archive
path in the host when build in docker.


  Commit: a1f0651170cee1edf505e361fd4b8ed89d222915
      https://github.com/RIOT-OS/RIOT/commit/a1f0651170cee1edf505e361fd4b8ed89d222915
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M sys/arduino/Makefile.include
    M sys/arduino/sketches.inc.mk

  Log Message:
  -----------
  Revert "sys/arduino: work around llvm-ar bug."

This reverts commit 72f934f13d6d50d5f2793f42842f410f5c08d277.

Not required anymore as 'ar' is not executed in the object directory
anymore.


  Commit: a019faaedd5155cfbb851b45a487f4de2ca0903f
      https://github.com/RIOT-OS/RIOT/commit/a019faaedd5155cfbb851b45a487f4de2ca0903f
  Author: Gaëtan Harter <gaetan.harter at fu-berlin.de>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M Makefile.include

  Log Message:
  -----------
  Makefile.include: use an os independant 'relpath'

This should now work on 'osx'.


  Commit: 92d5428d2e572baa8020b77b6b6730d94ef9cf0b
      https://github.com/RIOT-OS/RIOT/commit/92d5428d2e572baa8020b77b6b6730d94ef9cf0b
  Author: benpicco <benpicco at googlemail.com>
  Date:   2019-09-16 (Mon, 16 Sep 2019)

  Changed paths:
    M Makefile.base
    M Makefile.include
    M sys/arduino/Makefile.include
    M sys/arduino/sketches.inc.mk

  Log Message:
  -----------
  Merge pull request #12248 from cladmi/pr/makefile_base/thin_archive_fix

Makefile.base: implement relative path linking without 'realpath'


Compare: https://github.com/RIOT-OS/RIOT/compare/071c2b2c5f72...92d5428d2e57


More information about the commits mailing list