[riot-commits] [RIOT-OS/RIOT] 58beea: boards/mcb2388: define flank of the on-board button

Marian Buschsieweke noreply at github.com
Mon Apr 13 13:55:41 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: 58beead8054e251b59174ca82cad67c32ee26171
      https://github.com/RIOT-OS/RIOT/commit/58beead8054e251b59174ca82cad67c32ee26171
  Author: Benjamin Valentin <benpicco at googlemail.com>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M boards/mcb2388/include/board.h

  Log Message:
  -----------
  boards/mcb2388: define flank of the on-board button

Define the button flank for tests that use this define.


  Commit: 6233175f16f2efcae329f6347d74d823ae59d1cf
      https://github.com/RIOT-OS/RIOT/commit/6233175f16f2efcae329f6347d74d823ae59d1cf
  Author: Benjamin Valentin <benpicco at beuth-hochschule.de>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M cpu/lpc2387/periph/gpio.c

  Log Message:
  -----------
  cpu/lpc2387: gpio: Fix interrupts on PORT2

The calculation of `_state_index` is broken for `port = 2`

    _gpio_isr_map[n + (port<<1)];

Will not yield the right result. As a consequence, IRQs on Port 2
are not working.
The right thing here would be

    _gpio_isr_map[n + (port ? 32 : 0)];

But we might just re-using the `_isr_map_entry()` function.
Also only iterate as many times as there are set interrupt bits.


  Commit: cfe606b601d97f02713662e0bc521dc0f5db310b
      https://github.com/RIOT-OS/RIOT/commit/cfe606b601d97f02713662e0bc521dc0f5db310b
  Author: Benjamin Valentin <benpicco at beuth-hochschule.de>
  Date:   2020-04-12 (Sun, 12 Apr 2020)

  Changed paths:
    M cpu/lpc2387/periph/gpio.c

  Log Message:
  -----------
  cpu/lpc2387: gpio: Don't discriminate between rising & falling pins

The `test_irq()` function does not discriminate between rising and
falling pins, so there is no need to handle them separately.


  Commit: 54822ab5be45e0a0646725779ba21b49cee9475e
      https://github.com/RIOT-OS/RIOT/commit/54822ab5be45e0a0646725779ba21b49cee9475e
  Author: Marian Buschsieweke <maribu at users.noreply.github.com>
  Date:   2020-04-13 (Mon, 13 Apr 2020)

  Changed paths:
    M boards/mcb2388/include/board.h
    M cpu/lpc2387/periph/gpio.c

  Log Message:
  -----------
  Merge pull request #13857 from benpicco/cpu/lpc2387/gpio-fix_port2

cpu/lpc2387: gpio: Fix interrupts on PORT2


Compare: https://github.com/RIOT-OS/RIOT/compare/c68475eb0d61...54822ab5be45


More information about the commits mailing list