[riot-commits] [RIOT-OS/RIOT] a45066: cpu/atmega_common/periph: Fixed bug in PCINT

benpicco noreply at github.com
Thu Feb 6 18:29:18 CET 2020


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: a45066551b05a66238bd17b4761cfa948423f09b
      https://github.com/RIOT-OS/RIOT/commit/a45066551b05a66238bd17b4761cfa948423f09b
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2019-12-12 (Thu, 12 Dec 2019)

  Changed paths:
    M cpu/atmega_common/periph/gpio.c

  Log Message:
  -----------
  cpu/atmega_common/periph: Fixed bug in PCINT

The bank index and the pin number are not necessarily identical. For all
PCINT banks except for bank 3 bank_idx was used therefore. It was likely
just forgotten to update that for bank 3 as well.


  Commit: 3ecd303ed026dfe70524f4d883dd48151c24d185
      https://github.com/RIOT-OS/RIOT/commit/3ecd303ed026dfe70524f4d883dd48151c24d185
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2019-12-12 (Thu, 12 Dec 2019)

  Changed paths:
    M cpu/atmega_common/periph/gpio.c

  Log Message:
  -----------
  cpu/atmega_common/periph: Clean up PCINT support

- Using a enum instead of _COUNTER is easier to read
    - _COUNTER is also a reserved name; so better not use it to avoid issues
- Split out the pcint code into a static inline function for increased
  readability


  Commit: 24fb7a9aaeccd81900a9850e2cde71d2bf3550bd
      https://github.com/RIOT-OS/RIOT/commit/24fb7a9aaeccd81900a9850e2cde71d2bf3550bd
  Author: benpicco <benpicco at googlemail.com>
  Date:   2020-02-06 (Thu, 06 Feb 2020)

  Changed paths:
    M cpu/atmega_common/periph/gpio.c

  Log Message:
  -----------
  Merge pull request #12933 from maribu/atmega_pcint_cleanup

cpu/atmega_common/periph/gpio: Clean up PCINT support


Compare: https://github.com/RIOT-OS/RIOT/compare/e1c711e8cbc1...24fb7a9aaecc


More information about the commits mailing list