[riot-commits] [RIOT-OS/RIOT] f8ac00: base64: Fixed decode buffer size estimation

Martine Lenders noreply at github.com
Thu Jul 2 13:41:13 CEST 2020


  Branch: refs/heads/master
  Home:   https://github.com/RIOT-OS/RIOT
  Commit: f8ac003bbfe11956578dd2189827686c27374d06
      https://github.com/RIOT-OS/RIOT/commit/f8ac003bbfe11956578dd2189827686c27374d06
  Author: Maciej Jurczak <mjurczak at gmail.com>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    M sys/include/base64.h

  Log Message:
  -----------
  base64: Fixed decode buffer size estimation

Fixed required result buffer size underestimation in base64_estimate_decode_size() function.


  Commit: 3c7fd0cdc93c1a1be1ccdc394b5bd8d8aef7a303
      https://github.com/RIOT-OS/RIOT/commit/3c7fd0cdc93c1a1be1ccdc394b5bd8d8aef7a303
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    M sys/base64/base64.c
    M sys/include/base64.h

  Log Message:
  -----------
  sys/base64: Use void pointer for buffers in API

This is a non-breaking change, as `unsigned char *` can implicitly be converted
to `void *`.


  Commit: e3ea4943af4c5acfde3e68fb00fda2728e722b0d
      https://github.com/RIOT-OS/RIOT/commit/e3ea4943af4c5acfde3e68fb00fda2728e722b0d
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    A tests/bench_sys_base64/Makefile
    A tests/bench_sys_base64/main.c
    A tests/bench_sys_base64/tests/01-run.py

  Log Message:
  -----------
  tests: Add benchmark for sys/base64


  Commit: 4e6ec3493fbbff1f3e26bdb7dd10dbb5cdfe7582
      https://github.com/RIOT-OS/RIOT/commit/4e6ec3493fbbff1f3e26bdb7dd10dbb5cdfe7582
  Author: Marian Buschsieweke <marian.buschsieweke at ovgu.de>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    M tests/unittests/tests-base64/tests-base64.c

  Log Message:
  -----------
  tests/unittests: Extend & clean up base64 tests

- Added unit test for `base64_estimate_{de,en}code_size()`
- Mark constant stuff as `const`
- Use `memcmp()` for comparing memory
- Do not use variable size arrays
- Various code style issue


  Commit: 339e3faf21099640d31d170007b5f1accf4b56de
      https://github.com/RIOT-OS/RIOT/commit/339e3faf21099640d31d170007b5f1accf4b56de
  Author: Martine Lenders <m.lenders at fu-berlin.de>
  Date:   2020-07-02 (Thu, 02 Jul 2020)

  Changed paths:
    M sys/base64/base64.c
    M sys/include/base64.h
    A tests/bench_sys_base64/Makefile
    A tests/bench_sys_base64/main.c
    A tests/bench_sys_base64/tests/01-run.py
    M tests/unittests/tests-base64/tests-base64.c

  Log Message:
  -----------
  Merge pull request #14400 from maribu/base64_tests

sys/base64: Fix, unit test cleanup, and benchmark


Compare: https://github.com/RIOT-OS/RIOT/compare/045874abe6c0...339e3faf2109


More information about the commits mailing list