[riot-devel] [RFC] do not edit commits in a PR under review

Ludwig Ortmann ludwig.ortmann at fu-berlin.de
Mon Dec 2 10:24:39 CET 2013


P.S.:
Probably reordering/renumbering/merging into a prior point/... would
make sense.

On Mon, Dec 02, 2013 at 10:19:47AM +0100, Ludwig Ortmann wrote:
> Hi,
> 
> I'd add this paragraph to the Development Procedures [2]:
> 
> """
> 9. When updating a pull request, push the changes as individual commits so the
>    reviewers can tell how their comments have been addressed. (I.e. Refrain from
>    squashing/amending changes to the pull request immediately.)
> 
>    E.g.: "address comment by @UserName - fix license header
>           comment URL"
> 
>    Once the pull request gets acknowledged, these follow up commits should be
>    squashed in a reasonable manner before merging.
> """
> 
> Cheers, Ludwig
> 
> [2] https://github.com/RIOT-OS/RIOT/wiki/Development-procedures
> 
> 
> On Wed, Nov 27, 2013 at 02:20:21PM +0100, Oleg Hahm wrote:
> > Hi!
> > 
> > Ludwig recently suggested to add a rule to the coding conventions [1] to
> > forbid editing commits in an open Pull Request that is still under review. I
> > support this idea because otherwise it is difficult to keep track of the
> > development of the PR and integration of comments.
> > 
> > Any objections?
> > 
> > Cheers,
> > Oleg
> > 
> > [1] https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions
> > -- 
> > I saw your POST, but could only respond with OK - I guess I didn't GET it.
> 
> 
> 
> > _______________________________________________
> > devel mailing list
> > devel at riot-os.org
> > http://lists.riot-os.org/mailman/listinfo/devel
> 
> _______________________________________________
> devel mailing list
> devel at riot-os.org
> http://lists.riot-os.org/mailman/listinfo/devel


More information about the devel mailing list