[riot-devel] [RIOT] added cc110x driver changes (64223ae)

kaspar030 notifications at github.com
Mon Jul 15 19:23:46 CEST 2013


Did anyone ACK this commit?

Anyway, looks like a nice example of how NOT to commit. 

the commit
- has no meaningful commit message
- mixes style and functional changes
- changes debug settings
- seems to do more than one thing (non-atomic change), but as the commit message is meaningless, can't say
- does interesting things to copyright and author lines

I'm for reverting the commit. Can someone on site help Stephan cleaning up / seperating the changes?


---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/commit/64223ae6c5216af3e40f1c813e30cc6ec2a433f3#commitcomment-3636497
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20130715/1f129f34/attachment.html>


More information about the devel mailing list