[riot-devel] [RIOT] updated makefiles & a handler for the heap state shell command (#64)

Zakaria Kasmi notifications at github.com
Tue Jul 16 11:35:42 CEST 2013


> +
> +/**
> + * @file
> + * @internal
> + * @brief	Show the heap state for the LPC2387 on the command shell.
> + *
> + * @author      Freie Universität Berlin, Computer Systems & Telematics
> + * @author	Zakaria Kasmi <zkasmi at inf.fu-berlin.de>
> + *
> + * @note	$Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $
> + */
> +
> +extern void heap_stats(void);
> +
> +void _heap_handler(char* unnused){
> +	heap_stats();



Ø  you are just adding one line of production code

one “Line Of Production code” follows the same scheme as in “sc_ps.c”, “sc_id.c.”, etc.




---
Freie Universität Berlin
Institut für Mathematik/Informatik
Takustr. 9
14195 Berlin

Tel: +49 (0)30 838-75 144
Fax: +49 (0)30 838 75194
http://cst.mi.fu-berlin.de/staff/kasmi.html
---

Von: Christian Mehlis [mailto:notifications at github.com]
Gesendet: Montag, 15. Juli 2013 19:41
An: RIOT-OS/RIOT
Cc: Zakaria Kasmi
Betreff: Re: [RIOT] updated makefiles & a handler for the heap state shell command (#64)


In sys/shell/commands/sc_heap.c:

> +

> +/**

> + * @file

> + * @internal

> + * @brief   Show the heap state for the LPC2387 on the command shell.

> + *

> + * @author      Freie Universität Berlin, Computer Systems & Telematics

> + * @author  Zakaria Kasmi <zkasmi at inf.fu-berlin.de<mailto:zkasmi at inf.fu-berlin.de>>

> + *

> + * @note    $Id: sc_heap.c  3854 2013-05-24 17:53:01Z zkasmi $

> + */

> +

> +extern void heap_stats(void);

> +

> +void _heap_handler(char* unnused){

> +     heap_stats();

you are just adding one line of production code. please remove all "windows compat lines" and create one (1) commit and a new pull request.

—
Reply to this email directly or view it on GitHub<https://github.com/RIOT-OS/RIOT/pull/64/files#r5195888>.


---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/64/files#r5211550
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20130716/a45e7d28/attachment.html>


More information about the devel mailing list