[riot-devel] Comments from IRC

Hinnerk van Bruinehsen h.v.bruinehsen at fu-berlin.de
Sat Oct 11 19:28:04 CEST 2014


Hi,

the last few days there were two guys on IRC reviewing Riot for usability for
a project of theirs.
In the end sadly they deemed it too unfinished.
On the other hand one of them was kind enough to give some input on what he
deems amiss.
I assured him that I'd relay it to the right places for discussion:

> 2014-10-11 11:41:37	corecode	Hodapp: i didn't find anything
> 2014-10-11 13:49:26	Hodapp	corecode: hrm, could one use the 32 kHz clock that needs to be running anyhow for the softdevice?
> 2014-10-11 15:16:20	corecode	Hodapp: what do you mean by use?
> 2014-10-11 15:16:25	corecode	you can use RTC1
> 2014-10-11 15:27:25	corecode	Hodapp: but i don't think i'll use riot
> 2014-10-11 15:28:35	corecode	Hodapp: i've come across several bugs and odd design decisions that seem to originate from the code not being used in production
> 2014-10-11 15:29:01	corecode	like the rtt api... only one provider, no consumers, unclear what ticks even mean
> 2014-10-11 15:29:38	corecode	Hodapp: we're looking at freertos now
> 2014-10-11 15:33:29	+temmi_hoo	corecode: could you write an article of your findings to the riot-developers mailing list?
> 2014-10-11 15:35:49	corecode	not particularly interested
> 2014-10-11 15:36:02	corecode	it's a lot of small things
> 2014-10-11 15:36:23	corecode	i can dump it here, and somebody else can initiate some discussion
> 2014-10-11 15:41:43	@N8Fear_	corecode: I think any form of input would be appreciated
> 2014-10-11 15:45:11	corecode	ok
> 2014-10-11 15:45:28	corecode	my input is: stuff is not tested
> 2014-10-11 15:45:43	corecode	people seem to create APIs without applications that actually need them
> 2014-10-11 15:55:06	@N8Fear_	you said you also found some bugs: would you care to share what exactly?
> 2014-10-11 15:58:44	corecode	use of dINT/eINT or disableIRQ/enableIRQ instead of restoreIRQ
> 2014-10-11 15:59:34	corecode	the nrf timer code does not seem to be right/untested
> 2014-10-11 16:00:04	corecode	why do boards define soc peripherals, e.g. timers
> 2014-10-11 16:00:57	corecode	vtimer assumes 4096 seconds is a valid hwtimer value
> 2014-10-11 16:02:19	corecode	why does some code use both hwtimer and vtimer?
> 2014-10-11 16:02:32	corecode	what's the deal with if (!inISR()){ dINT();}
> 2014-10-11 16:02:39	corecode	etc.etc.
> 2014-10-11 16:02:52	corecode	and that's just after one day of looking at the source
> 2014-10-11 16:03:02	corecode	why is there immense copy+pasteness happening?
> 2014-10-11 16:03:17	corecode	hwtimer arch is copied all over the place
> 2014-10-11 16:03:59	corecode	it mostly looks like an effort to "support" many platforms
> 2014-10-11 16:28:14	corecode	N8Fear_: will you forward these points to the relevant places?
> 2014-10-11 16:28:30	@N8Fear_	sure
> 2014-10-11 16:31:48	@N8Fear_	otherwise I shouldn't have asked for your input. ;)
> 2014-10-11 16:31:53	@N8Fear_	thank you!
> 2014-10-11 18:31:37	corecode	my pleasure

Maybe we could take a look at the mentioned topics and see if we agree that
there are issue and - in that case resolve them - or discard them as non-issues
to us.

WKR
Hinnerk
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20141011/ed2873c6/attachment.sig>


More information about the devel mailing list