[riot-devel] Pull request procedure

Oleg Hahm oliver.hahm at inria.fr
Fri Aug 21 10:28:39 CEST 2015


Hi Cenk!

> I like your proposed guideline.

Thanks!
 
> What's your opinion on adding some words about logically splitting a PR
> across several commits. I always like it when a PR contains 1 commit for the
> new feature / bugfix and 1 commit for new/modified (unit)tests. This way I
> can review them separately in github.

Good idea. Although it should be already covered by point 7 of the Development
Procedures [1].

Cheers,
Oleg

[1] https://github.com/RIOT-OS/RIOT/wiki/Development-procedures
-- 
/* So there I am, in the middle of my `netfilter-is-wonderful'
   talk in Sydney, and someone asks `What happens if you try
   to enlarge a 64k packet here?'.  I think I said something
   eloquent like `fuck'. */
        linux-2.4.3/net/ipv4/netfilter/ip_nat_ftp.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20150821/3638fdf8/attachment.sig>


More information about the devel mailing list