[riot-devel] RFC: development procedures

Oleg Hahm oliver.hahm at inria.fr
Fri Aug 19 17:15:54 CEST 2016


Dear reviewing IoTlers,

looking at https://github.com/RIOT-OS/RIOT/pull/5758, I just realized that our
convention to add squash commits while a PR is under review may need an
amendment. If all commits that addresses a certain comment and are meant for
squashing have a non-speaking commit message (see linked PR), then it gets
more time-consuming for the reviewer to map a commit to a certain
review-reaction. Hence, I would propose to somehow reference the addressed
comment in the commit message. What do you think?

Cheers,
Oleg
-- 
printk(KERN_WARNING MYNAM ": (time to go bang on somebodies door)\n");
        linux-2.6.6/drivers/message/fusion/mptctl.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20160819/3d0f08e2/attachment.sig>


More information about the devel mailing list