[riot-devel] MRF24J40 radio module driver

Oleg Hahm oliver.hahm at inria.fr
Tue Sep 6 10:00:51 CEST 2016


Hey Alex!

On Tue, Sep 06, 2016 at 08:48:13AM +0200, Alexander Aring wrote:
> > In case netopt is "NETOPT_SRC_LEN" and the value is "IEEE802154_LONG_ADDRESS_LEN" (which is defined as 8U), this module sets the "NETDEV2_IEEE802154_SRC_MODE_LONG" flag.
> > 
> > https://github.com/RIOT-OS/RIOT/blob/master/drivers/netdev2_ieee802154/netdev2_ieee802154.c#L173
> >
> 
> I don't know why this goes down through the driver layer. The address
> filter doesn't need such information if you use as source address long
> or short.
> 
> For me it's unclear for what this sourc_len really is made for. I would
> suggest to use the best address setting which do the most smallest
> payload. Sure, there exists situation to overwrite such setting - but
> this should be done not as an interface setting.

Maybe I miss something, but how should the driver know which L2 address format
is expected at the receiver's side?

Cheers,
Oleg
-- 
HARDFAIL("Not enough magic.");
        linux-2.4.0-test2/drivers/block/nbd.c
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20160906/7eff3968/attachment.sig>


More information about the devel mailing list