[riot-devel] Lifting the 50 characters commit first line limit?

Joakim Nohlgård joakim.nohlgard at eistec.se
Wed Oct 10 09:31:27 CEST 2018


+1 what Martine wrote.

(I was composing a similar message when you beat me to it)
/Joakim

Den ons 10 okt. 2018 08:51Martine Lenders <mail at martine-lenders.eu> skrev:

> Hi Pekka,
>
> the 50 chars is just the warning bound. You can go up to 70 until the
> commit message check fails on you. Longer will make GitHub break the commit
> message in the webview with the dreaded […] ;-).
>
> My usual approach is to boil down the summary to the bare minimum within
> these constraints (even using just the module name instead of the full
> path) and go into details in the following lines of the commit message.
>
> Regards,
> Martine
>
> Am Mi., 10. Okt. 2018 um 08:06 Uhr schrieb Nikander Pekka <
> pekka.nikander at aalto.fi>:
>
>> [Refactoring the nRF520 mega-PR to follow the standards...]
>>
>> I guess this has been bashed to death, but I am annoyed.
>>
>> With long paths, the 50 characters limit on the first line
>> of the commit message makes it impossible to have any meaningful
>> explanation of what the commit actually does.  Actually,
>> the limitation makes the commit messages unintelligible.
>>
>> _Any_ change of increasing the limit to e.g. 72 characters?
>>
>> --Pekka
>>
>> _______________________________________________
>> devel mailing list
>> devel at riot-os.org
>> https://lists.riot-os.org/mailman/listinfo/devel
>>
> _______________________________________________
> devel mailing list
> devel at riot-os.org
> https://lists.riot-os.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/devel/attachments/20181010/4a8de9ef/attachment.html>


More information about the devel mailing list