<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    +1<br>
    <br>
    minor remark:<br>
    I would prefer writing `pull request` with lowercase letters. I
    couldn't find any significant occurences on google, where `pull
    request` is written with capital letters. It's fine for the subject,
    though. But then again, I would insist on also capitalizing
    `Creating` and `Good`.<br>
    <br>
    <div class="moz-cite-prefix">On 24.08.2015 17:55, Emmanuel Baccelli
      wrote:<br>
    </div>
    <blockquote
cite="mid:CANK0pbYkqgJS-aj7RuQqq4yxNnHTAJomL9QZoHk+8tHYXLE1yg@mail.gmail.com"
      type="cite">
      <div dir="ltr">+1</div>
      <div class="gmail_extra"><br>
        <div class="gmail_quote">On Mon, Aug 24, 2015 at 5:50 PM,
          rakendra thapa <span dir="ltr"><<a moz-do-not-send="true"
              href="mailto:rakendrathapa@gmail.com" target="_blank">rakendrathapa@gmail.com</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <p dir="ltr">+1</p>
            <div class="gmail_quote">
              <div>
                <div class="h5">On Aug 24, 2015 9:13 PM, "Oleg Hahm"
                  <<a moz-do-not-send="true"
                    href="mailto:oliver.hahm@inria.fr" target="_blank">oliver.hahm@inria.fr</a>>
                  wrote:<br type="attribution">
                </div>
              </div>
              <blockquote class="gmail_quote" style="margin:0 0 0
                .8ex;border-left:1px #ccc solid;padding-left:1ex">
                <div>
                  <div class="h5">Hi again!<br>
                    <br>
                    So, are there any objections about putting the
                    following into the Wiki?<br>
                    =====<br>
                    ## Guidelines for creating a good Pull Request<br>
                    <br>
                    * The title and initial description of a Pull
                    request should describe its<br>
                      basic idea and what goal is intended to be
                    achieved in a brief and<br>
                      comprehensible manner.<br>
                    * Try your best to document how the provided code is
                    intended to reach this<br>
                      goal. If the reviewer has difficulties to
                    understand your approach, try to<br>
                      improve the documentation.<br>
                    * Keep Pull requests as small as possible. The
                    smaller a PR, the more likely<br>
                      it gets reviewed in short time.<br>
                    * Split your PR up into logical pieces. E.g.
                    formatting changes or<br>
                      accompanying tests should go into separate
                    commits.<br>
                    * Support your reviewer! Try to react as quick as
                    possible to your reviewer's<br>
                      comments - and if only by letting her/him know,
                    that you have currently no<br>
                      time to incorporate her/his feedback. Also, let
                    the reviewer know if you do<br>
                      not plan to continue to work on a certain PR.
                    Furthermore, if your reviewer<br>
                      don't react for some days, remind him!<br>
                    =====<br>
                    <br>
                    If there's no objection until tonight, I will add
                    this to the Wiki.<br>
                    <br>
                    Cheers,<br>
                    Oleg<br>
                    --<br>
                    The bad thing with jokes around EOF<br>
                    <br>
                  </div>
                </div>
                <span class="">_______________________________________________<br>
                  devel mailing list<br>
                  <a moz-do-not-send="true"
                    href="mailto:devel@riot-os.org" target="_blank">devel@riot-os.org</a><br>
                  <a moz-do-not-send="true"
                    href="https://lists.riot-os.org/mailman/listinfo/devel"
                    rel="noreferrer" target="_blank">https://lists.riot-os.org/mailman/listinfo/devel</a><br>
                  <br>
                </span></blockquote>
            </div>
            <br>
            _______________________________________________<br>
            devel mailing list<br>
            <a moz-do-not-send="true" href="mailto:devel@riot-os.org">devel@riot-os.org</a><br>
            <a moz-do-not-send="true"
              href="https://lists.riot-os.org/mailman/listinfo/devel"
              rel="noreferrer" target="_blank">https://lists.riot-os.org/mailman/listinfo/devel</a><br>
            <br>
          </blockquote>
        </div>
        <br>
      </div>
      <br>
      <fieldset class="mimeAttachmentHeader"></fieldset>
      <br>
      <pre wrap="">_______________________________________________
devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:devel@riot-os.org">devel@riot-os.org</a>
<a class="moz-txt-link-freetext" href="https://lists.riot-os.org/mailman/listinfo/devel">https://lists.riot-os.org/mailman/listinfo/devel</a>
</pre>
    </blockquote>
    <br>
  </body>
</html>