[riot-notifications] [RIOT] Replace all numeric constants by macros (#136)

Oleg Hahm notifications at github.com
Thu Aug 15 22:11:59 CEST 2013


Let's not mix up things. I totally agree that macros should be avoided as much as possible, but still preprocessor directive defining `FOO` as `4711` is much better than using the number itself - and that was the purpose of this ticket.

I also agree that enums are much better - when it makes sense to use enums. (Btw, what's the difference between an anonymous enum and a preprocessor define?) The version using static const variables is nice, but sometimes not feasible if you want to provide the possibility to set the value from the command line or Makefile.

P.S. I don't care for any crappy GUI tools that cannot handle our source code properly.

---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/issues/136#issuecomment-22726592
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20130815/b24c1edd/attachment.html>


More information about the notifications mailing list