[riot-notifications] [RIOT] [WIP] cpu/sam3x8e: Add pwm implementation (#3170)

A-Paul notifications at github.com
Mon Jun 8 16:40:29 CEST 2015


> +     * Mode check.
> +     * Involves things that shold be in "periph_conf.h".
> +     * !Junk!Just wasting memory an a few cpu cycles for now. ;/
> +     */
> +    switch ( mode) {
> +    case PWM_LEFT:
> +        //!\todo
> +        break;
> +    case PWM_CENTER:
> +        //!\todo
> +        break;
> +    default:
> +        //retval = ERR_INIT_BWTH;
> +        // Don't like :/
> +        return ERR_INIT_BWTH;
> +    }

The same what should have happend to _PWM_CENTER_ at the moment. _default-case_ (which has the wrong error code also).
As it say in the comment, the block is useless for the moment and just does no harm.

I will implement the center align a few commits ahead, when I fixed other issues. Shall I:
- [] Cut it out and put it back in later?
- [] Let it stay (in shame) meanwhile?

---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/3170/files#r31920627
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20150608/84724f14/attachment.html>


More information about the notifications mailing list