[riot-notifications] [RIOT] drivers: add driver for encx24j600 ethernet chips (#2800)

Hauke Petersen notifications at github.com
Tue Jun 16 03:08:41 CEST 2015


> +
> +static inline int _set_promiscous(dev_eth_t *dev, int value) {
> +    return 1;
> +}
> +
> +const static eth_driver_t eth_driver_encx24j600 = {
> +    .init = _init,
> +    .send = _send,
> +    .recv = _recv,
> +    .get_mac_addr = _get_mac_addr,
> +    .get_promiscous = _get_promiscous,
> +    .set_promiscous = _set_promiscous,
> +    .isr = _isr,
> +};
> +
> +static inline void lock(encx24j600_t *dev) {

actually, it is not quite clear to me, why this device driver level locking is needed. The lower level SPI bus is protected by it's own lock, and the usage model of the network interface drivers so far is that they are only used inside a single thread (e.g. by a single user), so that device driver level locking is not really needed. Seems I am missing something?!

---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/2800/files#r32483444
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20150615/b89fa581/attachment.html>


More information about the notifications mailing list