[riot-notifications] [RIOT] gnrc_ipv6_netif: prepare for router discovery (#3745)

Cenk Gündoğan notifications at github.com
Tue Sep 1 18:36:43 CEST 2015


> -
> -/**
> - * @brief   Solicitates an advertisement of a neighboring router on this
> - *          interface.
> - *
> - * @param[in] netif The interface.
> - * @param[in] dst   The address of the neighboring router.
> - *                  May be NULL for @ref IPV6_ADDR_ALL_ROUTERS_LINK_LOCAL.
> - */
> -static inline void gnrc_ipv6_netif_sol_router(gnrc_ipv6_netif_t *netif, ipv6_addr_t *dst)
> -{
> -    (void)netif;    /* TODO */
> -    (void)dst;
> -}
> +void gnrc_ipv6_netif_set_rtr_adv(gnrc_ipv6_netif_t *netif, bool enable);
> +#else

Wouldn't it be much cleaner to separate those functions out of the current header file and include this file only if MODULE_XYZ is defined?

---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/3745/files#r38440582
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20150901/29533acd/attachment.html>


More information about the notifications mailing list