[riot-notifications] [RIOT] 6lowpan nd: router fixes (#3839)

Cenk Gündoğan notifications at github.com
Mon Sep 14 21:43:17 CEST 2015


> @@ -56,6 +56,22 @@ void gnrc_sixlowpan_nd_init(gnrc_ipv6_netif_t *iface)
>      gnrc_ndp_internal_send_rtr_sol(iface->pid, NULL);
>  }
>  
> +void gnrc_sixlowpan_nd_router_set_rtr_adv(gnrc_ipv6_netif_t *netif, bool enable)
> +{
> +    ipv6_addr_t all_routers = IPV6_ADDR_ALL_ROUTERS_LINK_LOCAL;

Question: There are two other lines like this in the ndp code [1] [2]. Would it make sense to expose **one** declaration instead and reuse it everywhere?

[1] https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/network_layer/ndp/internal/gnrc_ndp_internal.c#L307
[2] https://github.com/RIOT-OS/RIOT/blob/master/sys/net/gnrc/network_layer/ndp/router/gnrc_ndp_router.c#L31

---
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/3839/files#r39437664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20150914/d644a617/attachment.html>


More information about the notifications mailing list