[riot-notifications] [RIOT-OS/RIOT] sys/shell: adapt ifconfig to work with sx1272/76 devices (#7482)

Martine Lenders notifications at github.com
Sat Dec 9 19:53:40 CET 2017


miri64 requested changes on this pull request.



> @@ -31,6 +31,9 @@
 #ifdef MODULE_L2FILTER
 #include "net/l2filter.h"
 #endif
+#ifdef MODULE_SX127X
+#include "net/lora.h"
+#endif

Please remove all those `#ifdef`s and `#ifndef`s. They are not necessary. Especially the `#ifndefs` shouldn't be there. And if you want to keep the `#ifdef`s, please use another module (e.g. [a pseudo-module] `netdev_lora`).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7482#pullrequestreview-82332333
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20171209/cba88279/attachment.html>


More information about the notifications mailing list