[riot-notifications] [RIOT-OS/RIOT] pkg: add support for the tinycrypt library (#8269)

Kaspar Schleiser notifications at github.com
Mon Dec 18 14:48:32 CET 2017


kaspar030 requested changes on this pull request.



> @@ -0,0 +1,51 @@
+From a0e94f07ccf9c90ca49a905adc925b4ebfd8f0eb Mon Sep 17 00:00:00 2001

I propose copying this file, overwriting the one in the package sources, as other packages (like minmea) do.
Maintaining the patch is way more overhead.

> @@ -0,0 +1,125 @@
+/*  test_utils.h - TinyCrypt interface to common functions for tests */

If it is used as is, maybe adding the package's folder to the include path saves us from dealing with this?

> @@ -0,0 +1,2078 @@
+/* test_aes.c - TinyCrypt AES-128 tests (including NIST tests) */

same here - as the sources are already extracted to the package source folder in bin/pkg, maybe, with the right makefile (and maybe a small patch), it can be reused from there?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8269#pullrequestreview-84134780
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20171218/db54db81/attachment.html>


More information about the notifications mailing list