[riot-notifications] [RIOT-OS/RIOT] WIP: Adds crc_valid to netif (#8276)

Martine Lenders notifications at github.com
Tue Dec 19 09:22:56 CET 2017


miri64 commented on this pull request.



> @@ -205,13 +205,9 @@ int cc2420_rx(cc2420_t *dev, uint8_t *buf, size_t max_len, void *info)
 
         /* fetch and check if CRC_OK bit (MSB) is set */
         cc2420_fifo_read(dev, &crc_corr, 1);
-        if (!(crc_corr & 0x80)) {
-            DEBUG("cc2420: recv: CRC_OK bit not set, dropping packet\n");
-            /* drop the corrupted frame from the RXFIFO */
-            len = 0;
-        }

I don't like, that the dropping of the frame is removed completely. Shouldn't this be configurable?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/8276#pullrequestreview-84370112
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20171219/dafb54f5/attachment.html>


More information about the notifications mailing list