[riot-notifications] [RIOT-OS/RIOT] cpu/stm32f[0|1|3] unify stmclk with stm32_common (#7500)

Alexandre Abadie notifications at github.com
Fri Sep 1 09:27:54 CEST 2017


aabadie requested changes on this pull request.

Notes for stm32f3 are missing in the documentation of the clock configuration generator.

See the comments below.

I'll test on my f3 boards asap. Hope it can be merged today.

> @@ -8,10 +8,11 @@
  * @ref cpu_stm32f1, @ref cpu_stm32f2, @ref cpu_stm32f3, @ref cpu_stm32f4,
  * @ref cpu_stm32l4, @ref cpu_stm32f7.
  *
- * STM32F[2|4|7] Clock configuration
+ * STM32F[0|1|2|4|7] Clock configuration

f3 update missing here

>   * =================================
  *
- * stm32f2, stm32f4 and stm32f7 cpus share clock configuration code and macro.
+ * stm32f0, stm32f1, stm32f2, stm32f4 and stm32f7 cpus share clock configuration

stm32f3 missing

>   *  - CLOCK_PLL_M, CLOCK_PLL_N, CLOCK_PLL_P, CLOCK_PLL_Q: Main PLL factors
+ * The following macro must be defined for stm32f[0|1]:

f3 missing

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7500#pullrequestreview-60062973
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170901/ca0e4cc6/attachment.html>


More information about the notifications mailing list