[riot-notifications] [RIOT-OS/RIOT] Softspi (#7156)

Hauke Petersen notifications at github.com
Mon Sep 4 10:24:02 CEST 2017


Code looks ok to me, but I think the test application can/shoud be significantly improved. We could at least tell the user to connect MISO and MOSI pins via jumper wires and write the test so that it compares incoming and outgoing data.

Also I think the clock configuration must be implement to make the `soft_spi` driver meaningful. At least the low clock speeds can easily be implemented using `xtimer`, and we could simply restrict the clock speed to 100 and 400khz.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7156#issuecomment-326898313
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170904/8e491e2c/attachment.html>


More information about the notifications mailing list