[riot-notifications] [RIOT-OS/RIOT] sys/fmt: Small optimizations (#7366)

Kaspar Schleiser notifications at github.com
Mon Sep 4 13:18:32 CEST 2017


kaspar030 commented on this pull request.



> @@ -194,12 +194,12 @@ size_t fmt_u16_dec(char *out, uint16_t val)
 
 size_t fmt_s32_dec(char *out, int32_t val)
 {
-    int negative = (val < 0);
+    unsigned negative = (val < 0) ? 1 : 0;

> @gebart what do you think?

Just saw that you already replied. IMO if it is unclear which is better to read, let's lower the amount of characters that our poor brains need to parse.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7366#discussion_r136799673
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170904/ec97bf6c/attachment.html>


More information about the notifications mailing list