[riot-notifications] [RIOT-OS/RIOT] created and added Firefly board (#7401)

Alexandre Abadie notifications at github.com
Tue Sep 12 18:45:50 CEST 2017


aabadie requested changes on this pull request.

@AnonMall, I made a pass of style review. See my comments below.

> @@ -0,0 +1,111 @@
+Zolertia Firefly platform

Very nice documentation but IMHO it would be better to put it either at the beginning of board.h or in a separate `doc.txt` file.

> +
+/**
+ * @brief Initialize the boards on-board LEDs
+ *
+ * The LED initialization is hard-coded in this function. As the LED (RGB) are
+ * soldered onto the board they are fixed to their CPU pins.
+ */
+static inline void leds_init(void)
+{
+    gpio_init(LED0_PIN, GPIO_OUT);
+    gpio_init(LED1_PIN, GPIO_OUT);
+    gpio_init(LED2_PIN, GPIO_OUT);
+
+    /* Shoot rainbows */
+    LED_RAINBOW();
+

This empty line can be removed

> +/**
+ * @name UART configuration
+ * @{
+ */
+#define UART_NUMOF          (1U)
+#define UART_0_EN           1
+#define UART_IRQ_PRIO       1
+
+/* UART 0 device configuration */
+#define UART_0_DEV          UART0
+#define UART_0_IRQ          UART0_IRQn
+#define UART_0_ISR          isr_uart0
+/* UART 0 pin configuration */
+#define UART_0_TX_PIN       GPIO_PIN(0, 1)
+#define UART_0_RX_PIN       GPIO_PIN(0, 0)
+

This empty line can be removed

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7401#pullrequestreview-62194399
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170912/97524f96/attachment.html>


More information about the notifications mailing list