[riot-notifications] [RIOT-OS/RIOT] sam0:usart - wake from sleep on receive line (#7405)

Alexandre Abadie notifications at github.com
Fri Sep 15 10:48:34 CEST 2017


aabadie requested changes on this pull request.

Just one comment regarding a potential improvement of the proposed solution.

> @@ -111,6 +111,7 @@ static const uart_conf_t uart_config[] = {
         .rx_pad   = UART_PAD_RX_3,
         .tx_pad   = UART_PAD_TX_2,
         .runstdby = 0,
+        .wakeup   = false,

Maybe using a `uint8_t` `flags` field would help for future extension ? Then you can define the available flags in an `enum` and do some bitwise comparison in the driver instead of comparing to a boolean.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/7405#pullrequestreview-62980553
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20170915/3f960740/attachment.html>


More information about the notifications mailing list